On Tue, 6 Jan 2026 22:47:08 GMT, Chad Rakoczy <[email protected]> wrote:
>> [JDK-8369150](https://bugs.openjdk.org/browse/JDK-8369150) >> >> The test checks for JVMTI `COMPILED_METHOD_LOAD` and >> `COMPILED_METHOD_UNLOAD` events to be published for a relocated nmethod. It >> would originally intermittently fail if the JVM exited before it had time to >> publish the events so now it loops and forces GCs to encourage event >> publishing. The test fails if the events are received in the incorrect order >> (such as an unload before a load) or if the correct events are not received >> and the test times out. > > Chad Rakoczy has updated the pull request incrementally with one additional > commit since the last revision: > > Remove JNIenv use and update shouldExit Thank you for taking care about this issue and the updates! It looks good in general but I've posted one question. test/hotspot/jtreg/serviceability/jvmti/NMethodRelocation/NMethodRelocationTest.java line 108: > 106: while (!shouldExit()) { > 107: WHITE_BOX.fullGC(); > 108: } Q: Should we add a short sleep between calls to `WHITE_BOX.fullGC()`? ------------- PR Review: https://git.openjdk.org/jdk/pull/28683#pullrequestreview-3633030135 PR Review Comment: https://git.openjdk.org/jdk/pull/28683#discussion_r2666756291
