On Tue, 14 Oct 2025 05:37:43 GMT, David Holmes <[email protected]> wrote:
>> The return value of `JvmtiExport::post_class_file_load_hook` is never used, >> so we can remove the related dead code. >> >> Passes tier1 and tier2 (fastdebug). > > Sorry for ping-ponging on the serviceability labeling. I'm not sure this is > the right fix. The logic to return a value from `post_class_file_load_hook` > was added way back in JDK 9 by > [JDK-8171008](https://bugs.openjdk.org/browse/JDK-8171008) as part of the > original AOT compiler effort. But at that time no changes were made to any of > the callers to use the new return value! That means this aspect of the code > is completely untested - and it is also completely undocumented. > > I'd be more inclined to treat the `has_been_modified` aspect of > `JvmtiClassFileLoadHookPoster` as dead code and remove it again. But we need > serviceability folk to make that call - @plummercj or @sspitsyn ? Thanks for the feedback @dholmes-ora and @sspitsyn, I removed the dead code in 8fbf759. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27777#issuecomment-3405308607
