On Thu, 4 Sep 2025 00:12:48 GMT, Y. Srinivas Ramakrishna <y...@openjdk.org> wrote:
>> I had an error in GHA during my early implementation, so I included that >> header. I'll remove and test to see if it is needed or not. > > I believe you need it for this: > https://github.com/pf0n/jdk/blob/f43e334bf76f878ec688cbd58a5ab1cb10deb0f9/src/hotspot/share/memory/heapInspection.hpp#L218 > > It probably happens to work at other places because of preceding includes > that happen to satisfy this. Explicitly including it here makes sense for > that reason. Not sure why it just started showing up, but likely a new use > that didn't otherwise satisfy this include. I forgot to circle back on this, but there are files that I created that includes `heapInspection.hpp`. I get an incomplete type for the Mutex class if I don't include `mutex.hpp`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26977#discussion_r2320521485
