On Sat, 30 Aug 2025 02:13:20 GMT, Ioi Lam <ik...@openjdk.org> wrote:
> Rename `is_shared()` in `Metaspace` (and various other classes) to
> `in_aot_cache()` to reflect its true meaning:
> - tests if an object is inside the AOT cache's metaspace region.
>
> Also various forms of "shared metaspace" are updated to "aot metaspace"
>
> Please start your review with allocations.hpp
Good. In few places you used `AOTMetaspace` in comments and messages. But I
think it is fine. I assume you push this first.
test/hotspot/jtreg/runtime/cds/SpaceUtilizationCheck.java line 62:
> 60: WhiteBox wb = WhiteBox.getWhiteBox();
> 61: long reserve_alignment = wb.metaspaceSharedRegionAlignment();
> 62: System.out.println("AOTMetaspace::core_region_alignment() = " +
> reserve_alignment);
Here too.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27016#pullrequestreview-3171054693
PR Review Comment: https://git.openjdk.org/jdk/pull/27016#discussion_r2311956105
