On Tue, 19 Aug 2025 11:18:48 GMT, Albert Mingkun Yang <ay...@openjdk.org> wrote:
>> Jonas Norlinder has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused > > src/hotspot/share/gc/shared/collectedHeap.cpp line 625: > >> 623: ClassLoaderDataGraph::print_on(&ls_trace); >> 624: } >> 625: } > > I don't think this code movement should be done -- this calls back to > `Universe` and CLDG printing is not necessarily tired to heap. The motivation to move into `CollectedHeap::before_exit` is that now we finally have a specific method that is called for GC activites during exit so there is no need to conflate java.cpp with these tasks. > this calls back to Universe It called back to Universe in java.cpp too. Maybe you would want `Universe::print_on` to be refactored into CollectedHeap too? If that's the case maybe we should save that for a separate issue. > CLDG printing is not necessarily tired to heap That could be so, but it is put under `gc+exit` tag. Are you suggesting that we should break this apart and do it under another tag? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26621#discussion_r2285459470
