On Thu, 17 Jul 2025 02:39:15 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The fix added JVMTI stress testing mode. > > This mode enables stress agent that could be executed with jtreg test and > help to ensure that jvmti functionality doesn't break the other JVM/JDK > functionality. > > I filed few issues and more are coming. I want to push the agent so it is > possible to provide reproduces for problems uncovered by this agent. > > The agent has 2 modes now: > - regular that is compatible with most of tests including other jvmti, jdi > and jdb tests > - debugger, that additionally test some function requiring solo > capabilities and not compatible with debugger and some jvmti tests > > The tests incompatible wiht agent (IR, CDS) and some individual tests from > tier1 are excluded. There are not plans to support stable execution of all > tests with agent right now. However it provokes some crashes worth to be used > for exploratory testing. > Note, that flagless tests are excluded automatically and not executed in this > mode. make/RunTests.gmk line 64: > 62: > 63: AGENT_PREFIX := lib > 64: AGENT_EXT := .so We already have `LIBRARY_PREFIX` and `SHARED_LIBRARY_SUFFIX` defined in spec.gmk. To make those available in a test prebuilt scenario, they need to also be defined in RunTestPrebuiltSpec.gmk. Then you can use those instead of defining these. make/RunTests.gmk line 215: > 213: $(eval $(call ParseKeywordVariable, JTREG, \ > 214: SINGLE_KEYWORDS := JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT \ > 215: TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY > JVMTI_STRESS_AGENT MAX_MEM RUN_PROBLEM_LISTS \ Could you add this list element in a way that doesn't make the lines any longer? make/RunTests.gmk line 892: > 890: $1_JTREG_BASIC_OPTIONS += $$(addprefix > $$(JTREG_PROBLEM_LIST_PREFIX), $$(wildcard \ > 891: $$(addprefix $$($1_TEST_ROOT)/, ProblemList-jvmti-stress-agent.txt) \ > 892: )) Please use regular parentheses when referencing variables in makefiles. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2260294410 PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2260298782 PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2260294596
