On Thu, 10 Jul 2025 21:11:13 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: minor tweak of previous change > > src/hotspot/share/prims/jvmti.xml line 6233: > >> 6231: <error id="JVMTI_ERROR_OPAQUE_FRAME"> >> 6232: The implementation is unable to set the frame locals >> 6233: (e.g. the frame at <code>depth</code> is executing a native >> method). > > The situation here is a little different than other places where you removed > the special case for virtual threads. In the other cases above there was > already a description of the virtual thread support earlier in the > description of the API. However, for SetLocalObject the only description of > the virtual thread support is with the JVMTI_ERROR_OPAQUE_FRAME description, > which is now removed. I guess to be consistent with earlier APIs, the > description of virtual thread support should be added to the API description. > This should probably just be done once at the beginning in the "Local > Variable" section rather than separately for each API. Or you can re-add the > JVMTI_ERROR_OPAQUE_FRAME description here. Thank you for the comment. Yes, I was thinking about adding virtual thread specific clarification for `SetLocal*` to the general API description. I'll prepare and push an update. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26111#discussion_r2199542452
