On Wed, 2 Jul 2025 11:42:23 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> There is no guarantee of consistency when sampling jstat data, and we're
> asserting these figures are always consistent.
> Tests should retry some small number of times, rerunning the jstat tool to
> recapture data.
Marked as reviewed by lmesnik (Reviewer).
test/hotspot/jtreg/serviceability/tmtools/jstat/utils/JstatTool.java line 46:
> 44: for (int i = 1; i <= TRIES; i++) {
> 45: try {
> 46: results = measure();
Might be the 'measure' and 'assertConsistency' might be changed to from
'public' to 'package-local` if they are not needed to be used by tests directly.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26094#pullrequestreview-2983899660
PR Review Comment: https://git.openjdk.org/jdk/pull/26094#discussion_r2183255118
