On Tue, 1 Jul 2025 11:54:00 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update src/hotspot/share/prims/jvmtiImpl.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@users.noreply.github.com> >> - Update src/hotspot/share/prims/jvmtiImpl.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@users.noreply.github.com> > > This looks great. Thank you for sorting through all this code and my > speculation about the problem to find the real problem. For the record, I > don't think my change to remove is_running_emcp() caused this or any bug. I > wrote a test case for it yesterday and that code seems fine. Nice work > finding the real problem here and the straightforward solution. > There are several places in the JVM where we have to check for is_old() > methods to exclude them for various things. is_old() methods leaking into > places is a common bug pattern. This change is consistent with this approach > of fixing this. @coleenp Thanks. When I mention that your change is related to this problem, I meant related to this area. The change was correct and bug existed before. @dholmes-ora , @sspitsyn Thank you for review. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26031#issuecomment-3024630778
