On Thu, 26 Jun 2025 15:35:25 GMT, Ivan Walulya <iwalu...@openjdk.org> wrote:
>> Albert Mingkun Yang has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove-young-resize-after-full-gc
>
> src/hotspot/share/gc/parallel/psYoungGen.cpp line 305:
>
>> 303: eden_space()->top(),
>> 304: sizeof(HeapWord));
>> 305: if (word_size > available_word_size) {
>
> Would it be useful to `log_trace` this situaton?
You mean we are probably approaching OOM here? However, we can reach here from
diff calling-context, we don't know if we are near OOM or not.
> src/hotspot/share/gc/parallel/psYoungGen.cpp line 321:
>
>> 319: }
>> 320:
>> 321: void PSYoungGen::compute_desired_sizes(bool is_survivor_overflowing,
>
> Probably subjective, but as suggested on a recent review, is it easier to
> read if you returned the results in a Pair<size_t, size_t>?
It probably doesn't make much difference.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25000#discussion_r2169802849
PR Review Comment: https://git.openjdk.org/jdk/pull/25000#discussion_r2169790986
