On Wed, 25 Jun 2025 13:02:03 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> ThreadDumper/ThreadSnapshot need to handle a failure to resolve the native >> VM JavaThread from a java.lang.Thread. This is hard to reproduce but a >> thread that has since terminated can provoke a crash. Recognise this and >> return a null ThreadSnapshot. > > Kevin Walls has updated the pull request incrementally with two additional > commits since the last revision: > > - comment update > - comment update test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreadsWithEliminatedLock.java line 31: > 29: * @requires !vm.debug & (vm.compMode != "Xcomp") > 30: * @requires (vm.opt.TieredStopAtLevel == null | vm.opt.TieredStopAtLevel > == 4) > 31: * @requires vm.jvmti This seems like a separate discussion as the minimal VM doesn't have the M&M support so something isn't right if somehow is testing a run-time image that contains jdk.management and only the minimal VM. I assume it's just a drive-by change here but I think part of a bigger discussion. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25958#discussion_r2168202465
