On Thu, 19 Jun 2025 07:06:54 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> src/hotspot/share/oops/constantPool.cpp line 1944:
>>
>>> 1942: BSMAttributeEntry* e2 = bsm_attribute_entry(idx2);
>>> 1943: int k1 = e1->bootstrap_method_index();
>>> 1944: int k2 = cp2->e2->bootstrap_method_index();
>>
>> I'm kind of confused, this does not look right. It is event not going to be
>> compiled.
>> It is supposed to be as below:
>>
>> BSMAttributeEntry* e2 = cp2->bsm_attribute_entry(idx2);
>> . . .
>> int k2 = e2->bootstrap_method_index();
>> . . .
>> if (argc == e2->argument_count()) {
>> . . .
>> k2 = e2->argument_index(j);
>
> Gah, I accidentally made a mistake with the refactoring. Of course, when I
> pushed I thought "this change is so simple, no need to check it before
> pushing" :-). Let me fix that (and compile it myself this time)
It's okay unless you have not integrated the update. :)
Submitting at least 3 first mach5 tiers before integration will keep you out of
potential trouble.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25298#discussion_r2156332326
