On Tue, 17 Jun 2025 04:51:58 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update >> src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java >> >> Co-authored-by: Andrey Turbanov <turban...@gmail.com> >> - addressed review comments > > src/hotspot/os/posix/perfMemory_posix.cpp line 133: > >> 131: // >> 132: >> 133: #ifdef __APPLE__ > > This is a bit too much non-posix code in the posix file IMO. I'd rather see a > `MACOS_ONLY` call later on to something defined in `os_bsd.cpp` for macOS. Thanks @dholmes-ora , I moved the function to `os_bsd.cpp` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25824#discussion_r2155061182
