On Tue, 17 Jun 2025 22:29:24 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a byte buffer version and rename parameters.
>
> test/lib/RedefineClassHelper.java line 104:
>
>> 102: */
>> 103:
>> 104: public static byte[] replaceAllStrings(ClassLoader loader, String
>> oldString, String newString) throws Exception {
>
> Nit: I'd suggest to rename parameters:
> `oldString` => `oldClassName`
> `newString` => `newClassName`
>
> Alternatively, it is possible to pass bytecodes buffer instead of class
> loader and keep `oldString` and `newString` as before.
I wanted this code to also read bytecodes off the disk and not the caller do
that either. The code for getBytecodes or very similar is duplicated all over
the tests also.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25857#discussion_r2154384879
