On Wed, 21 May 2025 15:00:07 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo > > It looks like you removed the SA changes, so I'm not so sure you still need a > review from me. I just ask that you make sure the tests in serviceability/sa > and sun/tools/jhsdb all pass. I'm about to be OOO for a week, so I won't be > able to responds again until then. > @plummercj Could I ask you to withdraw the request for changes / clarify > further ? As I mentioned earlier: > It looks like you removed the SA changes, so I'm not so sure you still need a > review from me. I just ask that you make sure the tests in serviceability/sa > and sun/tools/jhsdb all pass. This still seems to be the case. Also, I don't think there is any formal way to withdraw a request for changes. Maybe I could mark it as reviewed, but that would be misleading since after you removed the SA changes there would not actually be any code in this PR that I would be reviewing, so I wouldn't want to be listed as a reviewer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24847#issuecomment-2949783839
