On Sat, 24 May 2025 20:41:06 GMT, John R Rose <jr...@openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add search table validation > > src/hotspot/share/oops/fieldInfo.cpp line 220: > >> 218: } >> 219: >> 220: #ifdef ASSERT > > Thank you for adding this. > > Suggest an additional check to validate the binary search: > > For each name/sig pair in the field stream, call the lookup function (or its > subroutine) and ensure that it steers to the right position in the field > stream. Done. This was really useful; I found a stupid error that caused reading in bad index if that was >= 256. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2109014830
