On Thu, 5 Jun 2025 01:09:01 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Renaming > > src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 88: > >> 86: return false; >> 87: } >> 88: } while (Atomic::cmpxchg(&_head, elementIndex, elementIndex + 1) != >> elementIndex); > > Why do we need atomic operations if we hold the enqueue lock. ?? Valid Point, I was probably over cautious. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2127957148