On Tue, 3 Jun 2025 14:10:52 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed comment
>
> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line
> 66:
>
>> 64: String s = VM.getSavedProperty("jdk.attach.allowAttachSelf");
>> 65: ALLOW_ATTACH_SELF = "".equals(s) || Boolean.parseBoolean(s);
>> 66: // For now the default is false.
>
> Shall we remove the comment? It was not obvious whether it applied to the
> code above, or below. 8-)
Yes, it's obsoleted.
Removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25192#discussion_r2124652335
