On Mon, 2 Jun 2025 18:39:33 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:

>> Passes the `Charset` read from the `stdin.encoding` system property while 
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>> 
>> `stdin.encoding` is a recently added property for Java 25 in 
>> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it 
>> throughout the entire code base is addressed by the parent ticket 
>> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357993 this 
>> PR is addressing is a sub-task of JDK-8356893 and is concerned with only 
>> areas related to Hotspot.
>
> Volkan Yazici has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Provide fallback for `stdin.encoding`

> > Can you clarify your testing?
> 
> @plummercj, green `tier1,2` results on 
> [45bdc4f](https://github.com/openjdk/jdk/commit/45bdc4fdaa17d0e9579154578cb9e3917e62c5c5)
>  are attached to the ticket. Would they suffice?

That's not going to be sufficient. The nsk tests are not being run until tier5.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25542#issuecomment-2936567479

Reply via email to