On Thu, 29 May 2025 19:21:42 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> Please review this small fix to update pipe mode for attach operation > communication. > - `FILE_FLAG_FIRST_PIPE_INSTANCE`: there is "retry" logic if pipe creation > failed [1], with this flag `CreateNamedPipe` fails when pipe with the same > name already exists; > - `PIPE_REJECT_REMOTE_CLIENTS`: attach works only for local processes, the > flag adds extra protection from remote connections. > > [1]: > https://github.com/openjdk/jdk/blob/master/src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java#L93 > > Testing: tier1..4, hs-tier5-svc This pull request has now been integrated. Changeset: ec02a87a Author: Alex Menkov <amen...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/ec02a87aeef008f6b2f94001fa33bac66bf24627 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod 8345745: Update mode of the Attach API communication pipe. Reviewed-by: sspitsyn, kevinw ------------- PR: https://git.openjdk.org/jdk/pull/25530
