On Tue, 27 May 2025 11:58:22 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> src/hotspot/share/jfr/periodic/sampling/jfrSampleRequest.cpp line 174: >> >>> 172: assert(request._sample_pc != nullptr, "invariant"); >>> 173: assert(jt != nullptr, "invariant"); >>> 174: assert(jt->thread_state() == _thread_in_Java, "invariant"); >> >> What? > > I also call this method for native stack traces in my implementation. As I > have to walk native stack traces at stackwalks. Assert for thread->state() == _thread_in_native then. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2117674370
