On Tue, 27 May 2025 11:11:13 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove assertion > > src/hotspot/share/jfr/periodic/sampling/jfrSampleRequest.cpp line 174: > >> 172: assert(request._sample_pc != nullptr, "invariant"); >> 173: assert(jt != nullptr, "invariant"); >> 174: assert(jt->thread_state() == _thread_in_Java, "invariant"); > > What? I also call this method for native stack traces in my implementation. As I have to walk native stack traces at stackwalks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2108995311
