On Thu, 29 May 2025 17:02:09 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Extend try block to cover debuggee.classByname() call. I would suggest 
>> disabling whitespace diffs when doing the review. It makes code movement and 
>> deletions more obvious.
>> 
>> There are a number of places where I removed a try/catch of 
>> InterruptedException around a Thread.sleep. This will now be handled by the 
>> outer try which was moved to before this try/catch.
>> 
>> Tested nsk/jdi test locally. Will do more thorough ci testing.
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   minor whitespace fix

Thank you for the reviews Leonid and Serguei!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25337#issuecomment-2923388133

Reply via email to