On Wed, 28 May 2025 03:51:36 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/services/threadService.cpp line 1180: > >> 1178: GrowableArray<OwnedLock>* _locks; >> 1179: Blocker _blocker; >> 1180: OopHandle _blocker_owner; > > Nit: Some short comments explaining the fields would be nice to have, at > least for `_depth`, `_retry_handshake`, `_locks`, `_blocker` and > `_blocker_owner`. after offline discussion agreed that in most cases additional explanations are not required ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2113108079
