On Tue, 27 May 2025 09:48:04 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
> Just a few drive-by questions: > > 1. Did you consider putting this implementation in another file, say > threadServices.hpp or even its own file? I'm asking because javaClasses seems > to have become a dumping ground for code that calls from Java code into the > JVM. It would be nice if we could put features into files that are named > after the feature. > > 2. Did you consider to put these OopHandle storages in something else > than Universe::vm_globals()? We have, for example, > ThreadService::_thread_service_storage. My concern about threadServices and _thread_service_storage was it's initialized conditionally. But now I see that they are always initialized. I'll try to move the stuff to threadServices.hpp/.cpp ------------- PR Comment: https://git.openjdk.org/jdk/pull/25425#issuecomment-2913633174
