On Sat, 17 May 2025 05:04:39 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being >> done with includevirtualthreads=y even though debuggers typically use the >> default includevirtualthreads=n. As a result we have a testing gap with >> includevirtualthreads=n. >> >> includevirtualthreads=y forces the debug agent to track all virtual threads >> so they are returned by vm.allThreads(). Some tests need this since they use >> vm.allThreads() to find the debuggee threads. Without >> includevirtualthreads=y, vm.allThreads() usually won't return any virtual >> threads (although it might return some for which events have been triggered). >> >> There are nearly 1200 nsk/jdi tests. There were about 350 tests that >> actually needed includevirtualthreads=y, but most of these have been >> addressed by other PRs, leaving the 20 or so tests being addressed in this >> PR. With this PR now defaulting to includevirtualthreads=n, the tests that >> require includevirtualthreads=y need to override the default by specifying >> the -includevirtualthreads @run option. > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > update copyrights test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/newInstance/newinstance001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValue/getvalue001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/getValues/getvalues001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/forceEarlyReturn/forceEarlyReturn001/forceEarlyReturn001.java line 2: > 1: /* > 2: * Copyright (c) 2007, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/name/name001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/suspend/suspend001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/suspendCount/suspendcount001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. The only change in the file is copyright update test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. one more test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose004/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. one more test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/suspend/suspend001/TestDescription.java line 1: > 1: /* one more test/hotspot/jtreg/vmTestbase/nsk/jdi/stress/serial/forceEarlyReturn001/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. one more test/hotspot/jtreg/vmTestbase/nsk/jdi/stress/serial/forceEarlyReturn002/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights > reserved. one more test/hotspot/jtreg/vmTestbase/nsk/share/jdi/TestDebuggerType2.java line 2: > 1: /* > 2: * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights > reserved. one more ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098647362 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098648012 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098648378 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098648645 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098649765 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098649896 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098650025 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098650158 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098650307 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098650514 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098650799 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098650969 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098651449 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098651599 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098651728 PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2098651980
