On Thu, 17 Apr 2025 15:18:11 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with eight >> additional commits since the last revision: >> >> - Update copyright >> - Add more error messages >> - Add more error messages >> - Add more error messages >> - Add more error messages >> - Add more error messages >> - Add more error messages >> - Add more error messages > > This is a good start for getting a reasonable error message without having to > first enable LIBSAPROC_DEBUG. A couple of suggestions for additional > improvements below: > > You've covered the top level error message in Pgrab_core(), but there are > many other print_debug messages that are for errors that are closer to the > root cause of the error. For example, look in core_handle_note() and > read_lib_info(). Also, Pgrab() needs updating, although it only has one debug > message, but it also is missing detecting when add_thread_info() or > read_lib_info() fails. > > add_map_info() and core_handle_prstatus() are lacking a print_error message > when they fail. Thanks @plummercj for the review! I added a few more print_error messages, converted some printf and print_debug to print_error, and added a new print_debug log to add_class_share_map_info, because the failure of that method is not fatal. Let me know if that looks better. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24722#issuecomment-2815080329
