On Wed, 9 Apr 2025 09:34:02 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> This is a long-standing oversight: HeapDumpPath does not recognise %p for >> pid expansion. >> The default filename uses a pid (e.g. java_pid1676937.hprof) but >> HeapDumpPath does not. >> It has always done a manual "root plus pid plus extension" on the default >> filename only, and >> should move to using Argument::copy_expand_pid() like we do with other such >> filenames. >> >> >> We also assumed the default filename is not a directory (which is very very >> likely, but doesn't have to be true). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > test feedback Looks good to me. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24482#pullrequestreview-2753028819
