On Mon, 17 Mar 2025 20:35:58 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The change fixes crash on AIX after JDK-8319055
> Can't test it on AIX, but the reason is obvious from the stack trace.
> AIX is the only platform that does not implement `reply_writer` yet
>
> Testing: sanity tier1
This is obviously a necessary fix (per the comment on `complete`.) and so I'm
hitting approve. But I'm not sure this is sufficient.
src/hotspot/share/services/attachListener.cpp line 130:
> 128: // If reply_writer is provided, writes the results.
> 129: void complete() {
> 130: if (_reply_writer != nullptr) {
Is this sufficient? I'm looking at JDK-8319055 for the first time and I can't
figure out how the value of `_reply_writer` affects the `_allow_streaming`
logic that accesses the reply-writer. We seem to enable streaming mode in
platform independent code, yet the availability of the reply-writer is platform
dependent! ???
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24089#pullrequestreview-2692593449
PR Review Comment: https://git.openjdk.org/jdk/pull/24089#discussion_r1999992737
