On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that >> are most likely not needed any more and could be removed. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > move code back in VMManagementImpl As pointed out already, we have a similar special setting here , should we also adjust this ? make/modules/java.base/lib/CoreLibraries.gmk-36-ifeq ($(call isTargetOs, linux)+$(COMPILE_WITH_DEBUG_SYMBOLS), true+true) make/modules/java.base/lib/CoreLibraries.gmk:37: LIBVERIFY_OPTIMIZATION := LOW make/modules/java.base/lib/CoreLibraries.gmk-38-endif make/modules/java.base/lib/CoreLibraries.gmk-39- make/modules/java.base/lib/CoreLibraries.gmk-40-$(eval $(call SetupJdkLibrary, BUILD_LIBVERIFY, \ make/modules/java.base/lib/CoreLibraries.gmk-41- NAME := verify, \ make/modules/java.base/lib/CoreLibraries.gmk:42: OPTIMIZATION := $(LIBVERIFY_OPTIMIZATION), \ make/modules/java.base/lib/CoreLibraries.gmk-43- DISABLED_WARNINGS_gcc_check_code.c := unused-variable, \ make/modules/java.base/lib/CoreLibraries.gmk-44- DISABLED_WARNINGS_clang_check_code.c := unused-variable, \ ------------- PR Comment: https://git.openjdk.org/jdk/pull/23966#issuecomment-2721937986
