On Tue, 11 Mar 2025 15:04:58 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Remove a compiler directive to avoid unused var warnings, but change the code > to make it imply a method has no return value when actually it returns a > value: I think you could argue this either way, so I asked if it's really > worthwhile. I can move this into a separate PR, maybe it is indeed much better to separate in because it isn't related to the OPTIMIZATION settings. Looking at the coding we might get '-1' back https://github.com/openjdk/jdk/blob/af9af7e90f7dab5adc7b89b76eb978d269e863de/src/hotspot/share/services/management.cpp#L491 so checking for the return code is probably a good idea (also at the other code location you mentioned). ------------- PR Comment: https://git.openjdk.org/jdk/pull/23966#issuecomment-2714714952
