On Tue, 4 Mar 2025 13:22:24 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Please review this trivial change to remove some unneeded includes and type >> declarations from vmStructs. The SystemDictionary type is unused because >> classes are looked up in the ClassLoaderDataGraph in the SA, and they >> haven't been in a single SystemDictionary for a very long time. >> Tested with SA tests locally. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Change the SystemDictionary section header comment too. I think that if classes are being removed from here that the friendship with VMStructs by those classes should also be removed. ------------- Changes requested by kbarrett (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23897#pullrequestreview-2657808981
