On Sun, 26 Jan 2025 20:27:32 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> The System Property "jmx.invoke.getters" was added in >> [JDK-4949203](https://bugs.openjdk.org/browse/JDK-4949203) to optionally be >> compatible with a time before JDK-6, when calling invoke on getters and >> setters was permitted. >> >> It should be removed. > > Kevin Walls has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove noSuchMethod method > - Remove removal warnings suppression Marked as reviewed by cjplummer (Reviewer). src/java.management/share/classes/com/sun/jmx/mbeanserver/PerInterface.java line 111: > 109: if (list == null) { > 110: final String msg = "No such operation: " + operation; > 111: throw new ReflectionException(new > NoSuchMethodException(operation + sigString(signature)), msg); I think this is much better, but I still think it's odd that `operation` is in both exceptions (after your changes it's a lot more clear that this is the case), but I'm okay with that for the sake of not risking any compatibility issues. ------------- PR Review: https://git.openjdk.org/jdk/pull/23132#pullrequestreview-2576564584 PR Review Comment: https://git.openjdk.org/jdk/pull/23132#discussion_r1931194592
