On Fri, 3 Jan 2025 13:02:07 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> This patch converts the remaining > test/jdk/com/sun/jdi/ClassUnloadEventTest.java from ASM to Class-File API. > > Please review. > > Thanks, > Adam Marked as reviewed by liach (Reviewer). test/jdk/com/sun/jdi/ClassUnloadEventTest.java line 72: > 70: ClassWriter cw = new ClassWriter(0); > 71: > 72: cw.visit(52, ACC_SUPER | ACC_PUBLIC, name, null, > "java/lang/Object", null); This anticipates an internal name but gets a binary name passed. This works in the old code accidentally because its classes were in the unnamed package. The port fixes this bug. ------------- PR Review: https://git.openjdk.org/jdk/pull/22915#pullrequestreview-2529398187 PR Review Comment: https://git.openjdk.org/jdk/pull/22915#discussion_r1901972466
