On Tue, 24 Dec 2024 15:45:24 GMT, Chen Liang <li...@openjdk.org> wrote:

>> I've tested this by running `make`, and the previous Makefile reports an 
>> error like file `test/lib/jtreg/SkippedException.java)` not found. So this 
>> fix is necessary.
>> 
>> I also checked the git log, this change was introduced in 
>> https://github.com/openjdk/jdk/pull/22420, not that long ago.
>
> Hmm, apparently this is not run as part of tier 1-3, which I ran in my patch. 
>  I wonder how this test is run.  And it means this patch needs to be 
> backported to 24.

Only this small piece would be appropriate for backport to 24.  I suggest 
splitting this out into its own bug,
fixing it in isolation, and backporting that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896952109

Reply via email to