On Mon, 16 Dec 2024 10:17:06 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
> [JDK-8319875](https://bugs.openjdk.org/browse/JDK-8319875) updated jcmd > System.map to support macOS but the tests are now failing on macosx-aarch64 > with ZGC. > > serviceability/dcmd/vm/SystemDumpMapTest.java > serviceability/dcmd/vm/SystemMapTest.java > > test SystemMapTest.jmx(): failure > java.lang.RuntimeException: '0x\\p{XDigit}+-0x\\p{XDigit}+ +\\d+ > +[\-rwx]*/[\-rwx]* +(pvt|tsh-shared) +(0x\\p{XDigit}+|\\d+) +JAVAHEAP.*' > missing from stdout/stderr > at jdk.test.lib.process.OutputAnalyzer.shouldMatch(OutputAnalyzer.java:372) > at SystemMapTest.run(SystemMapTest.java:50) > at SystemMapTest.jmx(SystemMapTest.java:57) > > The output from my runs says `tsh` and not `tsh-shared`. The following change > seems to work on my machine and on macosx-aarch64 and macosx-x64 in our CI > pipeline. > > @stooke @tstuefe Do you think this looks reasonable or was there some systems > that reported this as pvt-shared? Looks good! ...and trivial. Ship it. ------------- Marked as reviewed by eosterlund (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22759#pullrequestreview-2506224389
