On Fri, 13 Dec 2024 22:25:24 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> This increases MaxMetaspaceSize for this test so that it can be run with CDS > turned off. This change is upstreamed from the valhalla repo from when it > didn't have CDS on. The test still finds a metaspace leak with this larger > MaxMetaspaceSize. Changes requested by dholmes (Reviewer). test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java line 38: > 36: */ > 37: > 38: // MaxMetaspaceSize=23m allows InMemoryJavaCompiler to load even if CDS > is off. Suggestion: // MaxMetaspaceSize=25m allows InMemoryJavaCompiler to load even if CDS is off. ------------- PR Review: https://git.openjdk.org/jdk/pull/22746#pullrequestreview-2504739971 PR Review Comment: https://git.openjdk.org/jdk/pull/22746#discussion_r1885884633
