On Mon, 9 Dec 2024 20:52:14 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

> The fix looks good modulo potential renaming of the `run1()` method.

I think you and @AlanBateman did quite understand what I meant by:

> It also needs to support test runs with platforms threads. See how run() 
> checks if it is running in virtual thread mode or not. Either way it calls 
> run(), but in the virtual thread case it does so using VThreadPinner.

The `run1()` method is called regardless of whether or not we are using 
vthreads and VThreadPinner, so I don't think `runPinned()` is a good name for 
it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22620#issuecomment-2529505051

Reply via email to