On Fri, 15 Nov 2024 17:36:30 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Remove redundant SecurityManager, AccessController references
> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the
> Security Manager).
>
> src/jdk.management/share/classes/com/sun/management/internal/GarbageCollectionNotifInfoCompositeData.java
> There is an existing theoretical path where GcInfoBuilder stays null, should
> never happen, "com.sun.management.GcInfo" exists...
>
> src/jdk.management/share/classes/com/sun/management/internal/GcInfoCompositeData.java
> Similarly there is an existing assumption that
> Class.forName("com.sun.management.GcInfo") succeeds.
src/jdk.management/share/classes/com/sun/management/internal/GarbageCollectionNotifInfoCompositeData.java
line 72:
> 70: Field f = cl.getDeclaredField("builder");
> 71: f.setAccessible(true);
> 72: builder = (GcInfoBuilder) f.get(gcNotifInfo.getGcInfo());
Suggestion:
builder = (GcInfoBuilder)f.get(gcNotifInfo.getGcInfo());
src/jdk.management/share/classes/com/sun/management/internal/GcInfoCompositeData.java
line 77:
> 75: Field f = cl.getDeclaredField("builder");
> 76: f.setAccessible(true);
> 77: builder = (GcInfoBuilder)f.get(info);
Suggestion:
builder = (GcInfoBuilder)f.get(info);
src/jdk.management/share/classes/com/sun/management/internal/HotSpotDiagnostic.java
line 52:
> 50:
> 51: String propertyName =
> "jdk.management.heapdump.allowAnyFileSuffix";
> 52: boolean allowAnyFileSuffix =
> Boolean.parseBoolean(System.getProperty(propertyName, "false"));
can be simplified to `Boolean.getBoolean(propertyName)`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1847129967
PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1847133367
PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1847140386
