On Mon, 18 Nov 2024 07:27:07 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - static block not needed
>> - Merge remote-tracking branch 'upstream/master' into
>> 8344187_PostSM_instrument
>> - update
>> - 8344187: Remove SecurityManager and related calls from java.instrument
>
> src/java.instrument/share/classes/sun/instrument/InstrumentationImpl.java
> line 661:
>
>> 659: static final StackWalker walker;
>> 660: static {
>> 661: walker =
>> StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE);
>
> If you want, you could remove the static block, but what you have is okay too.
may as well 8-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22106#discussion_r1846357861
