On Sun, 17 Nov 2024 04:32:39 GMT, Ramkumar Sunderbabu <rsunderb...@openjdk.org> wrote:
> Trivial change to exclude the test from running with Xcomp flag. > > The test fails because the number of GCs as reported by the MXBean doesn't > match the expected number. This is due to the additional GC happening due to > CodeCache crossing its threshold. > We could increase the code cache or restrict the specific compiler that fills > the cache. But this will not completely eliminate the possibility as cache > size could be overridden or the same failure can happen for a different > compiler. > > So, it is better to restrict the Xcomp flag as a whole. > > Testing: > Only local testing done as it is trivial change. One run with Xcomp and > another without any flags. Agreed, looks good. ------------- Marked as reviewed by kevinw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22180#pullrequestreview-2441962585
