On Fri, 15 Nov 2024 05:22:40 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated the test with some comments.
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyError.java
> line 68:
>
>> 66: classWriter.visit(52, ACC_SUPER | ACC_PUBLIC,
>> "java/lang/VerifyError", null, "java/lang/LinkageError", null);
>> 67: {
>> 68: fieldVisitor = classWriter.visitField(ACC_PRIVATE |
>> ACC_FINAL | ACC_STATIC, "serialVersionUID", "J", null, new
>> Long(7001962396098498785L));
>
> Why do we need a serialVersionUID in this test class?
TEST RESULT: Failed. Execution failed: `main' threw exception:
java.lang.UnsupportedOperationException: class redefinition failed: attempted
to change the schema (add/remove fields)
Because it's a field in VerifyError
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1843695396
