On Fri, 25 Oct 2024 12:00:43 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 1440:
>>
>>> 1438: }
>>> 1439:
>>> 1440: ObjectMonitor* ObjectSynchronizer::inflate_impl(JavaThread*
>>> inflating_thread, oop object, const InflateCause cause) {
>>
>> `inflating_thread` doesn't sound right as it is always the current thread
>> that is doing the inflating. The passed in thread may be a different thread
>> trying to acquire the monitor ... perhaps `contending_thread`?
>
> If it's always the current thread, then it should be called 'current' imo.
I see that in lightweightSynchronizer.cpp we already use the name
`locking_thread` (although
`LightweightSynchronizer::inflate_into_object_header` still uses
`inflating_thread`). So how about using `locking_thread` instead? I can fix
`LightweightSynchronizer::inflate_into_object_header` too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1817389380
