On Tue, 5 Nov 2024 07:51:05 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Add oopDesc::has_klass_gap() check >> - Rename waitTimeout/set_waitTimeout accessors >> - Revert suggestion to ThawBase::new_stack_frame >> - Improve JFR pinned reason in event >> - Use freeze_result consistently > > src/hotspot/share/jfr/metadata/metadata.xml line 160: > >> 158: >> 159: <Event name="VirtualThreadPinned" category="Java Virtual Machine, >> Runtime" label="Virtual Thread Pinned" thread="true" stackTrace="true"> >> 160: <Field type="string" name="blockingOperation" label="Blocking >> operation" /> > > The label should be "Blocking Operation" with a capital "O". > > Labels use headline-style capitalization. See here for more information: > https://docs.oracle.com/en/java/javase/21/docs/api/jdk.jfr/jdk/jfr/Label.html Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1829463128