On Tue, 5 Nov 2024 08:19:34 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> src/hotspot/share/jfr/metadata/metadata.xml line 160: >> >>> 158: >>> 159: <Event name="VirtualThreadPinned" category="Java Virtual Machine, >>> Runtime" label="Virtual Thread Pinned" thread="true" stackTrace="true"> >>> 160: <Field type="string" name="blockingOperation" label="Blocking >>> operation" /> >> >> Previously, the event was in the "Java Application" category. I think that >> was a better fit because it meant it was visualized in the same lane in a >> thread graph. See here for more information about the category: >> >> https://docs.oracle.com/en/java/javase/21/docs/api/jdk.jfr/jdk/jfr/Category.html >> >> (Note: The fact that the event is now written in the JVM doesn't determine >> the category.) > > Thanks for spotting this, it wasn't intended to change the category. I think > it's that Event element was copied from another event when adding it to > metadata.xml and value from `@Category` wasn't carried over. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1829462765
