On Wed, 30 Oct 2024 02:18:00 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Yes. As Julian says, it's something we set up in our builds:
>>
>> if test "x$FLAGS_CPU_BITS" = x64; then
>> $1_DEFINES_CPU_JDK="${$1_DEFINES_CPU_JDK} -D_LP64=1"
>> $1_DEFINES_CPU_JVM="${$1_DEFINES_CPU_JVM} -D_LP64=1"
>> fi
>
> Ugghh! I was thrown by the `x` in test expressions and thought `x64` meant,
> well, x64 :)
Yeah, that idiom is indeed difficult to read. :-(
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822342078
