On Tue, 29 Oct 2024 22:12:56 GMT, Patricio Chilano Mateo <pchilanom...@openjdk.org> wrote:
>> src/hotspot/cpu/x86/interp_masm_x86.cpp line 359: >> >>> 357: push_cont_fastpath(); >>> 358: >>> 359: // Make VM call. In case of preemption set last_pc to the one we >>> want to resume to. >> >> From the comment, it sounds like we want to set last_pc to resume_pc, but I >> don't see that happening. The push/pop of rscratch1 doesn't seem to be >> doing anything. > > Method `MacroAssembler::call_VM_helper()` expects the current value at the > top of the stack to be the last_java_pc. There is comment on that method > explaining it: > https://github.com/openjdk/jdk/blob/60364ef0010bde2933c22bf581ff8b3700c4afd6/src/hotspot/cpu/x86/macroAssembler_x86.cpp#L1658 OK, I was looking for where it stores it in the anchor, but it doesn't, at least not until make_walkable() is called. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1821705135
