On Mon, 28 Oct 2024 21:00:35 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 186 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Update copyrights. Remove @compile line form Marshal.java test. >> - Update copyright headers >> - Adjust Executors.privilegedThreadFactory to make clear that thread uses >> current CCL >> - Merge branch 'master' into jep486 >> - ResourceBundle/modules/security/* no longer needed. TestPermission tested >> against getModule(String, Module) w/ SM. >> - remove privileged calls in logging/File* tests >> - delete PermissionTest.java as it simply constructs provider impls >> - remove non enforced/redundant comment in >> TestLogConfigurationDeadLockWithConf.java >> - clientlibs: Updated javax/swing/UIDefaults/6622002/bug6622002.java >> Removed createPrivateValue(), no longer used. >> - ... and 176 more: https://git.openjdk.org/jdk/compare/df3473e2...2f90c839 > > test/jdk/javax/xml/crypto/dsig/keyinfo/KeyInfo/Marshal.java line 30: > >> 28: * @modules java.xml.crypto/org.jcp.xml.dsig.internal.dom >> 29: * @compile -XDignore.symbol.file Marshal.java >> 30: * @run main/othervm/java.security.policy==test.policy Marshal > > With this change, the test now only compiles but doesn't run the test. It > could be a bug in jtreg since it is supposed to default to running the test > as "run main <test>" when there is no @run tag. In any case, the @compile > line is no longer necessary, so I will remove that, and then the test will be > run again. > > Also, missing a copyright update, will fix. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/548eb9e2eb3f586bbb620d5357fe3e5665aeb505 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1820743569
