On Mon, 28 Oct 2024 21:02:00 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 175 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Specify that params passed to getPermissions and implies are ignored and >> implies always returns false. >> - Change deprecated annotations to api notes on getPolicy and setPolicy. >> - clientlibs: Updated Problemlist >> Deleted javax/swing/JPopupMenu/6694823/bug6694823.java entry since it was >> determined that it is not a JDK bug but expected behavior on windows and >> linux platform. >> - clientlibs: Deleted JPopupMenu tests >> The following tests are deleted as they don't hold value without SM >> test/jdk/javax/swing/JPopupMenu/6691503/bug6691503.java - It tests that >> the popup are >> always-on-top for apps which doesn't hold value after SM removal. >> >> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java - Tests whether >> popup can overlap taskbar. >> Works differently on macOS and windows & linux but this is the expected >> behavior. >> Details in JDK-8342012. Not a functional issue. >> - clientlibs: GetSoundBankSecurityException.java renamed to >> EmptySoundBankTest.java >> - clientlibs: GetSoundBankSecurityException.java renamed to >> EmptySoundBankTest.java >> test renamed, test summary updated >> - Restore note for implementers in >> src/java.prefs/share/classes/java/util/prefs/AbstractPreferences.java >> - Change "SecurityManager" to "Security Manager". Add some missing code and >> linkplain tags. >> - Add api note to class description that permission checking is not >> supported and remove text about getting permissions from system policy. In >> getPermissions(), change "granted to the given codesource" to "for the >> codesource". >> - ... and 165 more: https://git.openjdk.org/jdk/compare/1476f6c4...e490f698 > > test/jdk/javax/xml/crypto/dsig/ErrorHandlerPermissions.java line 1: > >> 1: /* > > @wangweij It looks like this test can be deleted as it was specifically > trying to check that a `SecurityException` wasn't thrown, or did you think it > was still testing something useful? It can removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1820899380
