On Tue, 29 Oct 2024 00:19:29 GMT, Justin Lu <j...@openjdk.org> wrote:

>> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over 
>> `ExceptionOccurred()` when the usage is treating the return value as a 
>> boolean. This is part of the bigger umbrella issue: 
>> [JDK-8341542](https://bugs.openjdk.org/browse/JDK-8341542). 
>> 
>> 
>> 
>>>     ExceptionCheck
>>>     We introduce a convenience function to check for pending exceptions 
>>> without creating a local reference to the exception object.
>>> 
>>>     jboolean ExceptionCheck(JNIEnv *env);
>>> 
>>>     Returns JNI_TRUE when there is a pending exception; otherwise, returns 
>>> JNI_FALSE.
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   address other cases in Hotspot

Looks good. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21724#pullrequestreview-2401335566

Reply via email to